SUP-7157: Multiple consumers #13
Conversation
Alexander-Cairns
added
the
minor
WalkthroughA new Docker environment variable CONCURRENT_CONSUMERS (default "1") was introduced. The Java startup command now forwards this value to three system properties controlling concurrency: derivative.homarus.concurrent-consumers, derivative.houdini.concurrent-consumers, and derivative.ocr.concurrent-consumers. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as Operator
participant D as Docker Runtime
participant C as Container Env
participant J as Java Process
participant S1 as Homarus
participant S2 as Houdini
participant S3 as OCR
U->>D: Set CONCURRENT_CONSUMERS (optional)
D->>C: Start container with env
C->>J: Launch with -Dderivative.*.concurrent-consumers=${CONCURRENT_CONSUMERS}
J->>S1: Initialize with concurrent-consumers
J->>S2: Initialize with concurrent-consumers
J->>S3: Initialize with concurrent-consumers
note over S1,S3: Each service uses provided concurrency value
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
31-33: Add a safe default in case CONCURRENT_CONSUMERS is unset/emptyShell parameter expansion guards against accidental empty values (e.g., overridden as empty in Compose/K8s).
Apply this diff:
- -Dderivative.homarus.concurrent-consumers=${CONCURRENT_CONSUMERS} \ - -Dderivative.houdini.concurrent-consumers=${CONCURRENT_CONSUMERS} \ - -Dderivative.ocr.concurrent-consumers=${CONCURRENT_CONSUMERS} \ + -Dderivative.homarus.concurrent-consumers=${CONCURRENT_CONSUMERS:-1} \ + -Dderivative.houdini.concurrent-consumers=${CONCURRENT_CONSUMERS:-1} \ + -Dderivative.ocr.concurrent-consumers=${CONCURRENT_CONSUMERS:-1} \
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Dockerfile(2 hunks)
🔇 Additional comments (2)
Dockerfile (2)
12-12: ENV for concurrent consumers — LGTMGood addition. Defaulting to 1 keeps current behavior backward-compatible.
26-37: Verify derivative concurrency properties and resource recommendations
- Confirm that Alpaca 2.2.0 recognizes per-service concurrency keys—likely
derivative.homarus.concurrent-consumers,derivative.houdini.concurrent-consumers, andderivative.ocr.concurrent-consumers—by inspecting theexample.propertiesorapplication.propertiesbundled with the 2.2.0 release.- Document expected memory/CPU impact:
- Start with 1–2 consumers per service.
- Allocate approximately 512 MB of heap per consumer (e.g.,
-Xmx512m× N).- Don’t exceed one consumer per logical CPU core.
- Monitor broker-side and JVM metrics (ActiveMQ listener limits, GC pauses, CPU load) as you scale concurrency.
- Add these sizing guidelines and verification steps to your deployment docs or
alpaca.propertiesreference.
Summary by CodeRabbit